**** BEGIN LOGGING AT Sun Aug 14 02:59:58 2016
Aug 14 06:11:52 <Herrie|2> morning
Aug 14 06:19:30 <Tofe> Morning!
Aug 14 06:34:16 <Herrie> Latest nightly from server doesn't want to flash here :S
Aug 14 06:34:24 <Herrie> I guess it's the disk acting up :S
Aug 14 06:34:33 <Herrie> Time for that check LOL
Aug 14 06:34:37 <Herrie> So building locally now
Aug 14 07:49:14 <ka6sox> Herrie, its time to clean up the server again..you are almost out of spce...(burned 39GB in 8 days)
Aug 14 08:16:03 <Herrie> ka6sox: OK :S
Aug 14 08:16:09 <Herrie> Seems we need a script for that :P
Aug 14 08:16:53 <Herrie> In testing anything from before 09-aug-16 can be deleted.
Aug 14 12:18:39 <Herrie> Tofe: I have this in my log: Jul 30 15:17:51 mako LunaAppManager[1137]: file:///usr/palm/applications/org.webosports.app.phone/qml/main.qml:46: Error: Cannot assign [undefined] to int
Aug 14 12:18:45 <Herrie> Not sure what causes that?
Aug 14 12:18:54 <Herrie> It's on first boot
Aug 14 13:53:03 <EricBlade> Herrie: looks to me like ApplicationWindow.Pin is undefined
Aug 14 15:22:32 <Herrie> EricBlade: We do seem to have it here: https://github.com/webOS-ports/luneos-components/blob/64b96b1d51af5b51b19b59b6c1bc97ddca89a6c8/modules/LuneOS/Application/plugin/applicationwindow.cpp#l37
Aug 14 15:42:10 <EricBlade> you mean here? https://github.com/webOS-ports/luneos-components/blob/64b96b1d51af5b51b19b59b6c1bc97ddca89a6c8/modules/LuneOS/Application/plugin/applicationwindow.h
Aug 14 15:44:40 <EricBlade> i'm not seeing how it gets to the "application" object from the "ApplicationWindow" cpp plugin
Aug 14 15:46:45 <EricBlade> i'm a little confused as to how that code works. i'm guessing the actual application object is somewhere else
Aug 14 15:52:13 <Herrie> EricBlade: Me too ;) Tofe wrote it so he probably knows :P
Aug 14 15:52:34 <Herrie> We have luna-next, luneos-components, luna-next-cardshell that all fits together...
Aug 14 15:53:24 <Herrie> luna-next = black box to me :P
Aug 14 15:53:38 <Herrie> luneos-components and luna-next-cardshell I can work with :P
Aug 14 16:10:16 <nizovn> maybe we should use Q_ENUM instead of Q_ENUMS?
Aug 14 16:23:08 <Herrie> nizovn: Yeah seems Q_ENUMS is deprecated as per https://woboq.com/blog/q_enum.html
Aug 14 16:25:27 <nizovn> yup
Aug 14 16:33:22 <Tofe> Herrie, EricBlade: the application object is defined in the cpp and exposed to the qml engine from there
Aug 14 16:35:00 <Tofe> I'm on the way home, will be able to help more in a couple of hours
Aug 14 18:43:10 <Herrie> Tofe: OK :)
Aug 14 18:43:23 <Herrie> Seems my ICQ contacts are syncing now by the way :P
Aug 14 18:45:13 <Tofe> Good :)
Aug 14 18:54:02 <EricBlade> yeah, i'm still looking at it, maybe i should check it out and look at the whole thing, but i'm not seeing how ApplicationWindow in CPP ends up getting mapped into "application" in QML or whatever is happening there.
Aug 14 18:57:37 <Tofe> ah, no, it's not ApplicationWindow that gets mapped, it's the main Qt object in the luna-qml-launcher
Aug 14 18:57:41 <Tofe> let me find it
Aug 14 18:57:50 <EricBlade> i'm also seeing qml things that i'm not exactly familiar with -- like the app having several windows wrapped inside an Item .. i'm guessing that's something that wouldn't be normal elsewhere.. but then again, i've never tried it either
Aug 14 18:58:10 <Tofe> https://github.com/webOS-ports/luna-qml-launcher/blob/master/src/lunaqmlapplication.cpp#L203
Aug 14 18:58:54 <Tofe> The behavior of the "Window" type in QML is a bit disturbing yes
Aug 14 19:02:21 <EricBlade> ok, well, with that now I understand the whole function at least.
Aug 14 19:02:44 <EricBlade> So, shouldn't that enum reference be ApplicationWindow.Type.Pin ?
Aug 14 19:03:07 <EricBlade> i've never actuallly exported a CPP enum to QML though so I could be wrong.
Aug 14 19:03:56 <Tofe> Let me check that
Aug 14 19:04:32 <EricBlade> i'm probably wrong i see another example where someone indicates that should work
Aug 14 19:06:05 <Tofe> Looks ok; but as nizovn pointed out, we should probably migrate from Q_ENUMS to Q_ENUM
Aug 14 19:06:28 <EricBlade> yeah nvm i just found the docs, apparently that's how it works.  Seems strange, what if you had multiple enums with same value names ?
Aug 14 19:06:55 <Tofe> Yeah it's a bit broken I think
Aug 14 19:07:19 <Tofe> But you have the same issue in C++
Aug 14 19:08:24 <EricBlade> clearly, i write c++ code every day ;)  (more like i haven't touched c++ in about 3 years, and prior to that was about 15 years)
Aug 14 19:09:11 <EricBlade> so frequently when i look at it, i have to look things up
Aug 14 19:09:44 <Tofe> :)
Aug 14 19:10:02 <Tofe> Frankly, right now, I don't know why it doesn't work
Aug 14 19:10:20 <EricBlade> SO, my guess is that Herrie is not using the correct luneos-components plugin, *or* that somehow that particular value is just not available at that point in time, when onCompleted is run .. which doesn't make much sense to me either.
Aug 14 19:10:48 <EricBlade> since onCompleted should fire only after everything inside it has completed
Aug 14 19:11:03 <Tofe> I'd like to incriminate the luneos-components plugin too somehow
Aug 14 19:11:56 <Tofe> Well... It's time to start my N4 I guess :p
Aug 14 19:12:47 <EricBlade> it might be handy to console.warn(JSON.stringify(application)) at the end of that onCompleted .. and again sometime after that.
Aug 14 19:15:06 <Tofe> "qml: application = LunaQmlApplication(0xbeaadbf4)ApplicationWindow.Pin = undefined"
Aug 14 19:18:19 <Tofe> I'll have to update my build, it could take a little while
Aug 14 19:18:20 <Herrie|Laptop> Tofe: It could be just 1st boot....
Aug 14 19:18:26 <Herrie|Laptop> Not sure
Aug 14 19:18:49 <Tofe> Herrie|Laptop: no, I'm reproducing it after first boot by forcing the launchParams value
Aug 14 19:19:02 <Herrie|Laptop> Tofe: OK
Aug 14 19:19:22 <Herrie|Laptop> I'm looking into some of the FirstUse things. Seems some things aren't working like they should there...
Aug 14 19:19:55 <Tofe> Herrie|Laptop: keep in mind that some activities aren't run at first use, by design
Aug 14 19:20:16 <Herrie|Laptop> Tofe: Yeah, but this is more the FIrstUse app itself that has a few strange things :P
Aug 14 19:20:23 <Tofe> oh, ok
Aug 14 19:20:28 <Herrie|Laptop> Like the unprotected wifi not working :P
Aug 14 19:20:40 <Herrie|Laptop> Due to a sloppy call. I did a PR for that already
Aug 14 19:20:50 <Herrie|Laptop> But there are a few more wifi related things it seems.
Aug 14 19:20:58 <Herrie|Laptop> And also the timezones don't work in all cases
Aug 14 19:21:04 <Herrie|Laptop> EricBlade raised that one a while ago
Aug 14 19:22:04 <Tofe> I think some things work only if ofono had time to read infos from the SIM card
Aug 14 19:22:15 <Tofe> (and maybe the operator)
Aug 14 19:25:29 <Herrie|Laptop> Tofe: Yeah... Mine is fine, but for example on emulator it picks one that's 1 off where it should be... I.e. it picks Detroit/Chicago but it actually stores New York it seems...
Aug 14 19:25:33 <Herrie|Laptop> So that's something odd...
Aug 14 19:25:41 <Herrie|Laptop> I always get Amsterdam for mine :P
Aug 14 19:25:47 <Herrie|Laptop> When I have a sim inserted :P
Aug 14 19:27:35 <Tofe> https://github.com/webOS-ports/org.webosports.app.phone/pull/47 works. The worrying part is that I don't know why...
Aug 14 19:28:19 <Herrie|Laptop> Tofe: I think I did a similar fix for Browser... I saw it being used like this elsewhere :P
Aug 14 19:28:41 <Tofe> Herrie|Laptop: yes, it's one of your PR that made me try this here
Aug 14 19:28:55 <Herrie|Laptop> Also not sure why it's like this....
Aug 14 19:29:05 <Tofe> There must be a nasty namespace conflict somewhere
Aug 14 19:29:36 <Herrie|Laptop> Yeah
Aug 14 19:30:26 <Herrie|Laptop> Tofe: Maybe because QT has an ApplicationWindow type as well?
Aug 14 19:30:33 <Tofe> Oh, do they ?
Aug 14 19:30:50 <Herrie|Laptop> Seems so, introduced in QT 5.1: http://doc.qt.io/qt-5/qml-qtquick-controls-applicationwindow.html
Aug 14 19:30:59 <Herrie|Laptop> That would explain :P
Aug 14 19:31:04 <Tofe> ah in Controls... that's why...
Aug 14 19:31:18 <Tofe> so when we import Controls, we have that conflict
Aug 14 19:31:50 <Tofe> ok, we should rename our ApplicationWindow to LuneOSWindow or something similar, someday
Aug 14 19:32:25 <Herrie|Laptop> Tofe: Yeah to avoid confusion that would be good
Aug 14 19:33:08 <Tofe> I'll first update my mako build, I worked with qemu these last weeks and it's a bit behind
Aug 14 19:33:48 <Herrie|Laptop> Tofe: Good luck on the webengine :P
Aug 14 19:34:17 <Tofe> mmh ? why ?
Aug 14 19:34:45 <Herrie|Laptop> It always takes long ;)
Aug 14 19:35:09 <Tofe> ah! ok :) Not that long here, but yeah, an hour or so...
Aug 14 19:35:57 <Herrie|Laptop> Tofe: YEah same here ;)
Aug 14 19:36:15 <Herrie|Laptop> Would be good if it would use the resources more wisely... I think it's doing single thread/core only?
Aug 14 19:36:49 <Tofe> for the build?
Aug 14 19:37:57 <Tofe> I'm using 4 build threads and 4 bb threads
Aug 14 19:38:21 <Tofe> With the SSD and the 16GB RAM, it's pretty happy
Aug 14 19:39:49 <Herrie|Laptop> Tofe: For webengine itself...
Aug 14 19:40:02 <Herrie|Laptop> Just seems slow, even with SSD and lots of ram ;)
Aug 14 19:40:26 <Herrie|Laptop> Seems I might have messed up the LNC recipe by bumping it instead of phone app.... Fixed now, but your build might complain..
Aug 14 19:40:32 <Herrie|Laptop> Too little coffee today :P
Aug 14 19:40:39 <Tofe> It did complain :p
Aug 14 19:41:51 <Herrie|Laptop> Should be fine now when you update
Aug 14 19:42:01 <Tofe> yes, looks good
Aug 14 19:43:03 <Tofe> Now it's just a matter of waiting
Aug 14 19:43:42 <Tofe> I'll prepare the ApplicationWindow rename; do you agree for LuneOSWindow ? Or do you have a better idea?
Aug 14 19:44:04 <Herrie|Laptop> No LuneOSWindow should be fine
Aug 14 19:44:14 <Tofe> ok, let's go
Aug 14 19:44:56 <Herrie|Laptop> It shouldn't be in many places it seems... LuneOSComponents itself, phone, browser that's it
Aug 14 19:48:39 <EricBlade> umm... oh, yeah, ApplicationWindow is used in the phone app lol
Aug 14 19:52:39 <EricBlade> while you're renaming things... "application" sounds like a pretty poor name for a global object injected into the system.
Aug 14 19:53:03 <EricBlade> just a thought.
Aug 14 19:54:19 <Herrie|Laptop> EricBlade: We thought about LuneOSWindow, does that make sense?
Aug 14 19:54:46 <EricBlade> well.. is it really a window?
Aug 14 19:56:08 <EricBlade> ok yeah
Aug 14 19:56:34 <nizovn> Herrie|Laptop: seems two functions in your phone app PR's are not used anywhere https://github.com/webOS-ports/org.webosports.app.firstuse/pull/25/files#diff-da31d02da53cf7c3eec52dc973decc9eR237
Aug 14 19:56:35 <EricBlade> LuneOSWindow seems a bit clunky to have to type all the time, so that would be my only complaint there..
Aug 14 19:57:06 <nizovn> Herrie|Laptop: oops firstuse app, not phone
Aug 14 19:58:33 <EricBlade> but if it's just that you have to import it once and create it once, that's not so bad. but if you constantly have to refer to enums or things, maybe just LuneWindow ? shrug. doesn't matter to me, just want to make sure it's not likely to ever collide with something outside of Lune
Aug 14 20:01:04 <Tofe> EricBlade: mostly, it's just a one-time use per QML app
Aug 14 20:01:13 <Tofe> The phone app is an exception
Aug 14 20:02:13 <Herrie|Laptop> nizovn: Should I have placed it inside the } in the line above?
Aug 14 20:11:03 <nizovn> Herrie|Laptop: in service.call you use connectNetworkSuccess callback, but then define later networkConnectSuccess function
Aug 14 20:12:50 <Herrie|Laptop> nizovn: clearly too little coffee today :P
Aug 14 20:16:38 <nizovn> :)
Aug 14 20:31:15 <Herrie|Laptop> OK updated PR
**** ENDING LOGGING AT Mon Aug 15 02:59:58 2016