**** BEGIN LOGGING AT Thu Aug 25 02:59:58 2016 Aug 25 08:19:14 Herrie: I'm going to move the test QML import of qofono into luneos-components, and remove it from the phone app. You see any argument against doing so? Aug 25 08:56:36 Herrie: I would need some context regarding browser's code: I see you are testing addressBar.selectedText !== "" in several places, but I don't see why; how is the url selected text playing a role, apart from clipboard treatments? Aug 25 08:57:25 https://github.com/webOS-ports/org.webosports.app.browser/blob/master/qml/NavigationBar.qml#L1022 here for instance Aug 25 09:32:27 Tofe: It should show certain icons only when there's a content in the url bar Aug 25 09:32:33 At least that's what I think Aug 25 09:32:42 I can have a look later and confirm on 3.0.5 if you wan Aug 25 09:32:43 +t Aug 25 09:36:04 For the QML import no objections, makes sense imho to have it in a central place Aug 25 10:06:59 ok Aug 25 12:03:06 Tofe these timers with addressBar.text is just a condition to display it like legacy Aug 25 12:03:54 I think webkit had webView.loadProgress === 100 even when no page was loaded yet (i.e. browser just started). Hence I added the addressBar.text as 2nd criteria Aug 25 12:14:20 The .text I can understand, but it's the .selectedText that is a bit too subtle for me Aug 25 13:17:22 Tofe: House full of guests at the moment since little one is 2 today :P Well we're actually moving to the park now :P Aug 25 13:17:29 But can look tonight I guess Aug 25 13:25:04 Happy birthday little one :) Have a nice day! Aug 25 13:34:18 whose birthday? Aug 25 13:38:28 My son is 2 today :P Aug 25 13:38:49 So we moved from the sauna apartment to the park next to us with moms & children :P Aug 25 13:38:54 Tofe: thnx Aug 25 13:42:14 Making some bbq, put a small pool for the children, they're decorating and eating cupcakes :P Aug 25 13:52:13 Herrie|Pre3: oh nice! :) Aug 25 16:57:37 I don't understand - what's the difference between search and find in db8 ? Aug 25 16:58:29 search is simply find with the additional '?' operator? Aug 25 17:18:33 Tofe: Seems so: find - Finds objects matching a query. and Searches for objects matching a query. Supports the "?" operator, which you can use for full-text searching. Aug 25 17:39:40 Tofe: On the selectedText: It seems that the icon changes on legacy when you select the text Aug 25 17:39:44 So I replicated that Aug 25 17:40:07 oh, ok Aug 25 17:40:11 thx Aug 25 17:40:27 I just took 3.0.5 browser and replicated it's behavior Aug 25 17:40:39 Can be done nicer I'm sure in many cases but "it worked" :P Aug 25 17:40:49 This was my first QML project so I'm sure it's messy :P Aug 25 17:41:22 Well, mh, a little bit :p But I'm changing bits here and there progressively Aug 25 17:42:14 Right now I'm changing the way the various dialogs and panels are shown/hidden Aug 25 17:43:20 The main problem with the current code is that all the components are referencing all the others, without going through properties to separate things a bit Aug 25 17:43:32 So it works, but it's fragile Aug 25 17:49:57 Tofe: I wasn't familiar with properties back then yet :P Aug 25 17:49:58 LOL Aug 25 17:50:13 But yeah can really use some restructuring and cleanup Aug 25 17:50:24 that the whole idea :) Aug 25 17:50:45 Also I wanted to see how it worked in details Aug 25 18:23:27 Tofe: Yeah that's always useful :D **** ENDING LOGGING AT Fri Aug 26 02:59:59 2016