**** BEGIN LOGGING AT Sun Aug 28 02:59:58 2016
Aug 28 10:54:38 <Herrie> morning
Aug 28 10:55:16 <Tofe> hi!
Aug 28 11:06:12 <Herrie> Tofe: While you're QML-ing you might want to replace the hardcoded ringtone in Phone app ;)
Aug 28 11:06:22 <Herrie> Since it can be dynamically selected in Settings
Aug 28 11:06:34 <Tofe> I'm always QML-ing ;)
Aug 28 11:07:52 <Herrie> https://github.com/webOS-ports/org.webosports.app.phone/blob/8188e320424448324401472b1ccb9ed130bd16f5/qml/services/RingManager.qml#L51
Aug 28 11:09:39 <Herrie> I'd need to have luna://com.palm.systemservice/getPreferences '{"keys":"ringtone"}'
Aug 28 11:46:12 <Herrie> s/I'd/It'd
Aug 28 11:59:31 <Tofe> Ok, I think I'm ready to do a big QML PR
Aug 28 12:22:41 <Tofe> mmh I've broken one thing on two on device
Aug 28 12:23:14 <Tofe> mainly the db find for history, bookmarks and suggestions
Aug 28 12:23:21 <Tofe> Let's investigate
Aug 28 12:27:39 <Herrie> Tofe: I noticed it was flaky originally too sometime
Aug 28 12:27:47 <Herrie> So could be it's not you, but good to check
Aug 28 12:27:55 <Herrie> I noticed it randomly as well
Aug 28 12:29:16 <Tofe> well, your way of updating it was incorrect, in  the sense you would read sometimes results before they are provided
Aug 28 12:32:48 <Herrie> Tofe: I just noticed it was glitchy
Aug 28 13:03:17 <Tofe> ok, issue was that I made a mistake with how the history item is put in db
Aug 28 13:12:10 <Tofe> The tests on device don't show obvious flaws, so I'll PR and let you judge
Aug 28 13:12:39 <Tofe> It relies on the LuneOSWindow renaming, so I'll PR that too
Aug 28 13:15:02 <Tofe> ah, no, silly me, it was already merged. Good.
Aug 28 13:17:08 <Tofe> There could have been other minor improvements, but one must stop at some point
Aug 28 13:40:48 <Herrie> Ooh that's a lot of stuff to review :D
Aug 28 13:57:47 <Herrie> Tofe: House full of guests now, but should have time tonight to test & review ;)
Aug 28 14:05:59 <Tofe> no hurry, the PR will still be there tomorrow :p
Aug 28 15:20:47 <ka6sox> Herrie, are you a moderator on the mailing list?
Aug 28 15:24:07 <Herrie> ka6sox: Nope, should be though ;)
Aug 28 15:24:26 <ka6sox> let me see if I can figure out how to make you one.
Aug 28 15:46:44 <Tofe> I think only morphis is
Aug 28 19:40:07 <Herrie> Tofe: Phone & Components looked straight forward so merged them and doing a build locally so I can then test browser changes
Aug 28 20:55:35 <Tofe> ok !
**** ENDING LOGGING AT Mon Aug 29 02:59:58 2016