**** BEGIN LOGGING AT Sun Sep 04 02:59:58 2016
Sep 04 06:03:33 <Herrie|2> morning
Sep 04 06:03:44 <Herrie|2> Tofe: my context menu is not grey anymore?
Sep 04 06:03:56 <Herrie|2> Is that expected? Earlier version you showed was dark grey
Sep 04 06:23:58 <Herrie|2> Ah on 3.0.5 it's also like that
Sep 04 06:27:29 <Herrie|2> Tofe: All merged
Sep 04 08:25:10 <Tofe> Herrie: yup, I changed it to look like 3.0.5 :)
Sep 04 08:25:13 <Tofe> Morning
Sep 04 08:59:21 <Tofe> nizovn: how would you redesign the contextual menu function ( https://github.com/webOS-ports/qtwebengine/blob/webOS-ports/master/src/webengine/api/qquickwebengineview.cpp#L209 ), roughly ?
Sep 04 08:59:55 <Tofe> I guess it's all about removing some bits, adding "if" here and there, moving things a bit
Sep 04 09:01:45 <Tofe> also, in what I proposed there is no sub-menu
Sep 04 09:09:45 <nizovn> morning
Sep 04 09:10:40 <Tofe> Morning :)
Sep 04 09:12:02 <nizovn> Tofe: i think legacy context menu is quite good, but we can take some features from android as well
Sep 04 09:12:18 <nizovn> so i think back forward and reload are redundant
Sep 04 09:13:06 <nizovn> and "follow link" too, i don't understand what it's for..
Sep 04 09:13:42 <nizovn> from android we can take e.g. "open in private card" or something like that for incognito mode
Sep 04 09:17:14 <nizovn> we also could show full url in the top of context menu, as in android, but not 100% sure we need that
Sep 04 09:17:47 <nizovn> Tofe: ok, no sub-menu is far better :)
Sep 04 09:18:17 <Tofe> urls are quite long, these days, not sure if we should show it... Or maybe just the text of the URL
Sep 04 09:18:50 <Tofe> back, forward, follow, reload, we can throw away yes
Sep 04 09:19:59 <Tofe> We could place our additional items at the beginning, instead of at the end
Sep 04 09:20:37 <nizovn> yup, agree
Sep 04 09:24:20 <Tofe> So: [open in new card; open in new private card, share link, copy url or copy text, and some multimedia controls
Sep 04 09:26:27 <Tofe> I hesitate if we should simply skip the additional items when there's no URL, or if we should find a way to make it a bit flexible
Sep 04 09:28:41 <Tofe> ah, I've done already :D
Sep 04 09:28:45 <Tofe> +it
Sep 04 09:29:42 <nizovn> Tofe: you made new custom context menu?
Sep 04 09:30:52 <nizovn> if there's no url we should ideally go into selection mode, but it's for future...
Sep 04 09:36:47 <Tofe> nizovn: https://github.com/webOS-ports/org.webosports.app.browser/blob/master/qml/ContextMenu.qml
Sep 04 09:50:32 <nizovn> Tofe: btw do we get context menu in web apps? not sure we need that
Sep 04 09:51:07 <Tofe> possibily yes
Sep 04 09:51:18 <Tofe> We should deactivate it
Sep 04 10:32:30 <Tofe> nizovn: I think we could simplify a lot the current management of clicks, but I'm not sure to understand exactly why the JS code is for
Sep 04 10:35:18 <Tofe> also,   adjustSelection and getSelectedData are never called, making me wonder if we shouldn't simply put them away
Sep 04 10:35:56 <Tofe> nizovn: I'll propose a cleanup PR, and you'll decide what we do about it :)
Sep 04 10:40:07 <nizovn> Tofe: that code was imported from some qml browser for context menu support (and never used functions were left just in case they could help in future for searching text/selection, etc)
Sep 04 10:40:49 <nizovn> with newer qt we seems don't need this at all
Sep 04 10:41:14 <Tofe> Ok, so let's not use it and see what it does
Sep 04 10:41:49 <Tofe> Overloading click and window.open events is worrying me
Sep 04 14:22:52 <Herrie> Tofe: How I can test your PR?
Sep 04 14:30:12 <Tofe> Herrie: go to pivotCE, and click on the facebook logo in the sidebar on the left; that'll trigger a new window open, and crash.
Sep 04 14:31:21 <Tofe> The crash occurs because we use the newly created window very soon, and some internal pointer in WebEngine are not yet initialized. It's a pity that they don't test their pointer more.
Sep 04 14:31:45 <Herrie> Ah OK
Sep 04 14:31:47 <Tofe> I'll try to PR that to Qt 5.6 when I'll get the time to that in shape
Sep 04 14:31:59 <Tofe> +put
Sep 04 14:50:23 <Tofe> https://codereview.qt-project.org/#/c/170097/
Sep 04 14:52:43 <Herrie> Tofe: :D
Sep 04 14:52:48 <Herrie> Doing a local build now
Sep 04 15:03:59 <Tofe> I'll propose a PR for browser, which doesn't use the "userscript" anymore - it shouldn't have any impact on the functionalities
Sep 04 15:06:57 <Herrie> Tofe: OK :)
Sep 04 15:07:45 <Tofe> https://github.com/webOS-ports/org.webosports.app.browser/pull/63 <-- this one. I kept the .js file just in case. It would worth testing with a bit of browsing to see if I introduced anything nasty, but I don't think so.
Sep 04 15:07:55 <Tofe> nizovn: ^
Sep 04 17:42:39 <Herrie|TP> Tofe: On your webengine PR - browser update it opens 2 card with url for me when I press Facebook, Google+ on PivotCE. This is with Mako.
Sep 04 17:43:16 <Tofe> 2 ? I had only one with qemu...
Sep 04 17:43:47 <Herrie|TP> Tofe: BTW you remember what issues we had with connman 1.3.2? I have 1.3.3 here and I seem to get working wifi. Need to test calls & BT still but do seem to get cell signal OK
Sep 04 17:44:20 <Herrie|TP> Tofe: Yeah 2. Or do I need the browser update too to test?
Sep 04 17:47:13 <Tofe> not necessarily, the webengine PR was just to avoid it crashing
Sep 04 17:47:32 <Tofe> but please try with my browser PR too, just in case it fixes it :) which is possible
Sep 04 17:52:43 <nizovn> Tofe: we can drop qwebchannel.js as well
Sep 04 17:56:49 <nizovn> PR looks good, i agree 2 cards can be caused by two ways of detecting links to open in new card, e.g. we had two context menus for a long time
Sep 04 18:08:03 <Tofe> nizovn: yes, we can drop qwebchannel.js too, I forgot :)
Sep 04 18:12:45 <nizovn> Tofe: oops, i also forgot, we can cleanup COPYING a little too :)
Sep 04 18:13:29 <nizovn> ah, i understood, after testing
Sep 04 18:18:14 <Herrie> Tofe: Seems OK with Browser PR added
Sep 04 18:18:32 <Herrie> Are they Ok to merge or you want do the cleanup mentioned above first?
Sep 04 18:21:41 <Tofe> Herrie: maybe I can do the cleanup now
Sep 04 18:23:53 <Tofe> Cleanup cpushed
Sep 04 18:23:54 <Herrie> nizovn: I'll ping JaMa when he's around for the TP PR
Sep 04 18:25:57 <nizovn> Herrie: ok, thanks. i hope you remember the process of compiling new kernel version :)
Sep 04 18:31:43 <Herrie> nizovn: Ehm no :P
Sep 04 18:31:52 <Herrie> But we'll see... Build doesn't do it automatically?
Sep 04 18:32:05 <Herrie> Lets take it 1 step at a time :P
Sep 04 19:03:00 <Tofe> Isn't every linux user supposed to know all about kernel compilation? :p
Sep 04 19:28:41 <nizovn> :)
Sep 04 19:29:10 <nizovn> Herrie: seems it's semi-automatic http://logs.nslu2-linux.org/livelogs/webos-ports/webos-ports.20150805.txt
**** ENDING LOGGING AT Mon Sep 05 02:59:58 2016