**** BEGIN LOGGING AT Wed Nov 29 03:00:02 2017 Nov 29 08:08:16 Morning! Nov 29 08:42:00 Morning! Nov 29 15:00:01 Tofe: Sorry been a bit hectic here Nov 29 15:00:02 https://bpaste.net/show/f261820234dc Nov 29 15:00:09 signapk issue it seems Nov 29 15:00:15 Seems like a Java version issue actually Nov 29 15:00:34 I copy the signapk.jar with cp ${BUILD_DIR}/prebuilts/sdk/tools/lib/signapk.jar ${BUILD_DIR}/out/host/linux-x86/framework/ Nov 29 15:00:44 But it doesn't seem to work properly Nov 29 15:11:46 I guess we could also just try to skip QtiTelephonyService Nov 29 15:11:57 It seems to be pure java stuff Nov 29 15:13:10 Tofe: Not sure Nov 29 15:13:20 It seems something qualcomm related to RIL Nov 29 15:13:22 Not sure we need it? Nov 29 15:13:29 bshah: ^ thoughts? Nov 29 16:40:58 Tofe: Question is where to disable it :S Nov 29 17:22:37 Tofe: Seems https://github.com/TheMuppets/proprietary_vendor_xiaomi/blob/cm-14.1/mido/mido-vendor.mk Nov 29 17:23:28 So far needed to remove QtiTelephonyService, TimeService, datastatusnotification, embms, shutdownlistener due to signapk Nov 29 17:23:34 Not sure if that's desired? Nov 29 17:48:40 well, what's weird is that piggz didn't need to Nov 29 17:50:26 but anyway, if it's an apk I don't see how it would be started within halium Nov 29 17:56:24 Tofe: To properly patch this I'd need to add a patch to luneos hal right? Nov 29 17:56:34 right Nov 29 17:56:38 Or fork but I guess keeping piggz and luneos hal patch might be better Nov 29 17:56:45 you know how this works? Nov 29 17:57:03 I create a patch and simply add it there? Or there's more to it? Nov 29 17:57:19 And add the luneos hal to our wop-default.xml Nov 29 17:57:22 basically you keep the directory structure down to the directory associated to the git repo, and the patch goes there Nov 29 17:57:47 follow the other vendor examples in there and all should be well :) Nov 29 17:57:54 Tofe: OK so i clone the git, patch it there and put the .patch in luneos hal? Nov 29 17:58:06 you don't even need to clone it Nov 29 17:58:22 It was still running when I checked a while ago Nov 29 17:58:23 do your modifications locally, commit it, and do a git format-patch -1 Nov 29 17:58:26 Out for most of tonight Nov 29 17:58:36 Tofe: Well that's what I meant Nov 29 17:58:39 ah ok :) Nov 29 17:58:49 First get it to build Nov 29 17:59:02 Mido sshould come tomorrow maybe Nov 29 17:59:15 just be careful not to apply the patches twice, or unapply twice: there is barely no checks Nov 29 18:20:24 Tofe: bitbake works nicer for that Nov 29 18:20:26 :P Nov 29 21:55:29 Tofe: OK getting a missing include now Nov 29 21:55:39 linux/lirc.h not found Nov 29 21:56:02 device/xiaomi/mido/consumerir/consumerir.c:23:10: fatal error: 'linux/lirc.h' file not found #include Nov 29 21:56:20 I guess this is some infrared stuff Nov 29 21:59:06 It should find that in https://github.com/piggz/android_kernel_xiaomi_msm8953/tree/cm-14.1/kernel right? Nov 29 21:59:08 Or.... ? Nov 29 22:25:37 Tofe: Seems we might need something like https://github.com/billchen1977/android_device_xiaomi_kenzo/commit/8addd98f6ec0f2bffd3ceb04d7fec608ac93ee2f Nov 29 22:32:51 Seems we have https://github.com/piggz/android_kernel_xiaomi_msm8953/blob/pgz-14.1-eb6/include/media/lirc.h so could just be patching include path Nov 29 23:16:13 Tofe: Hmmz when I simply change linux to media it doesn't work. Tofe: Ideas? Nov 29 23:17:04 For now nastily added lirc.h in the consumerir folder but that's not ideal of course Nov 29 23:26:04 Sorry wasn't there... And now to bed; I'll try to help tomorrow :) **** ENDING LOGGING AT Thu Nov 30 03:00:02 2017