**** BEGIN LOGGING AT Wed May 02 03:00:04 2018
May 02 03:18:16 <Adam____> I guess I'll try to get back here later! I'm really excited to try this out. Will I have to buy a Nexus 5?
May 02 03:18:24 <Adam____> Does a Nexus 5X work?
May 02 05:46:03 <Herrie> Morning!
May 02 07:18:33 <Tofe> Morning!
May 02 07:20:06 <Herrie|Laptop> Morning!
May 02 14:22:47 <Herrie|Laptop> Tofe: Should have those nyx modules ready in a bit ;)
May 02 14:22:52 <Herrie|Laptop> So you can take it from there
May 02 14:24:13 <Herrie|Laptop> Got MTP, ALS and LED migrated it seems
May 02 14:24:20 <Herrie|Laptop> Keys, haptics & touchpanel to go
May 02 14:39:19 <Tofe> ok, thanks ! :)
May 02 14:46:44 <Herrie|Laptop> I need to tidy up some commits but it's building
May 02 14:46:55 <Herrie|Laptop> I guess once all builds and work we'd need to see how to PR to upstream but well
May 02 14:49:11 <Tofe> Herrie|Laptop: It'll be a good example for LG guys that it's not just one-sided contribution
May 02 14:54:07 <Herrie|Laptop> Well I already PR-ed a few more things so far
May 02 14:54:10 <Herrie|Laptop> Small but well
May 02 14:54:58 <Herrie|Laptop> Stuff like https://github.com/webosose/activitymanager/pull/1
May 02 14:55:05 <Herrie|Laptop> And https://github.com/webosose/db8/pull/1
May 02 14:55:09 <Herrie|Laptop> I'm sure there will be more
May 02 14:57:59 <Tofe> well, it's rarely about changing the whole code anyway :)
May 02 15:21:02 <Herrie|Laptop> Yup
May 02 15:21:05 <Herrie|Laptop> There are more we can PR
May 02 15:21:11 <Herrie|Laptop> But will do some things gradually ;)
May 02 15:25:05 <Herrie|Laptop> Tofe: This is as far as I got
May 02 15:25:14 <Herrie|Laptop> Touchpanel, touchpanel_mtdev and keys missing still
May 02 15:25:17 <Herrie|Laptop> https://github.com/Herrie82/nyx-modules/commits/herrie/msm_mtp
May 02 15:26:20 <Herrie|Laptop> There's a touchpanel in qemux86 so we should compare that with ours
May 02 16:45:26 <Tofe> ok ! I'll take it from there ! :)
May 02 16:48:05 <Herrie> Tofe: Keys I have more or less odne too
May 02 16:48:10 <Herrie> So take touchscreen ;)
May 02 16:51:33 <Tofe> ok :)
May 02 16:55:16 <Tofe> Herrie: for keys, battery, did you see that it's there in https://github.com/webosose/nyx-modules-qemux86/tree/master/src ?
May 02 16:56:04 <Tofe> ah no battery is fine you didn't add it
May 02 17:01:02 <Herrie|TP> Tofe: No for keys there are some minor diffs will have a look at those a bit later
May 02 17:01:29 <Herrie|TP> I.e. they mapped some more keys and seems there are some more functions, so will dig into that
May 02 17:02:15 <Herrie|TP> Since we have some bits in keys_common that they still have in keys but doesn't look shocking really
May 02 17:02:45 <Herrie|TP> For touchscreen you compare ours and the qemux86 one
May 02 17:03:04 <Herrie|TP> See if there are diffs that might also need to apply for the mtdev one
May 02 17:03:14 <Herrie|TP> Shouldn't be rocket science though
May 02 17:07:32 <Tofe> I had a look, it's far from rocket science :)
May 02 17:07:56 <Herrie> Yup hence I managed so far
May 02 18:16:01 <Tofe> Herrie: not tested yet, but https://github.com/Tofee/nyx-modules/commit/b807d77793be0a63d39a8b4aba7c72ec43aefb11
May 02 18:53:45 <Herrie> Tofe: OK
May 02 18:53:47 <Herrie> Thnx
May 02 18:54:06 <Herrie> It looks good in general
May 02 18:54:14 <Herrie> I just wonder how we hook this up to specific targets
May 02 18:55:26 <Herrie> I guess we'd need to update https://github.com/webOS-ports/meta-webos-ports/blob/pyro/meta-luneos/recipes-webos/nyx-modules/nyx-modules/mako.cmake etc /
May 02 18:55:27 <Herrie> ?
May 02 18:56:41 <Herrie> I.e. In OSE they do: https://github.com/webosose/meta-webosose/blob/master/meta-webos/conf/distro/include/webos-preferred-providers.inc#L68 and https://github.com/webosose/meta-webosose/blob/master/meta-webos/classes/webos_nyx_module_provider.bbclass
May 02 18:56:46 <Herrie> We can add the modules there
May 02 18:56:54 <Herrie> But then not sure how to include them for each target etc
May 02 18:57:01 <Herrie> Or we do that with our cmake files?
May 02 19:13:03 <Tofe> Herrie: I'm not sure yet
May 02 19:16:23 <Herrie> Tofe: Seems the nyx_module_check that we used: https://github.com/openwebos/nyx-modules/blob/9e8e441e4d84c3fba600030b03e36cbd335da847/src/CMakeLists.txt#L39 to get the mapping is gone
May 02 19:16:42 <Herrie> I mean mapping from NYXMOD_OW_SYSTEM to MODULE_SYSTEM_WEBOS_LINUX which then is used in cmake file
May 02 19:23:26 <Herrie> Ah seems we could simply do: $ cmake -D WEBOS_INSTALL_ROOT:PATH=$HOME/projects/webosose -DNYX_MODULES_REQUIRED="NYXMOD_QEMU_BATTERY;NYXMOD_QEMU_CHARGER;NYXMOD_QEMU_KEYS;NYXMOD_QEMU_TOUCHPANEL" ..
May 02 19:23:32 <Herrie> AS per https://github.com/webosose/nyx-modules-qemux86/blob/b2654ca6c3d343d7dfd33ec73d1d3b68f0588a6f/README.md
May 02 19:23:40 <Herrie> So that shouldn't be too hard
May 02 19:23:44 <Herrie> I'm sure there are other ways
May 02 19:23:53 <Herrie> JaMa: ^ Any thoughts?
May 02 19:24:33 <Tofe> Herrie: it looks like a per-device setup, shouldn't be put that in the machine configuration ?
May 02 19:37:39 <JaMa> Herrie: the original idea was to build all possible modules and then install only the subset useful for given device, but that wasn't ever fully implmented as everything in webOS is MACHINE_ARCH by default anyway
May 02 19:38:30 <JaMa> I mean build all modules, package them in separate packages and then install useful subset of nyx-module packages
May 02 19:45:14 <Herrie> JaMa: OK that is what seems happens now in OSE from what I can tell?
May 02 19:45:18 <Herrie> I mean build all
May 02 19:45:34 <Herrie> We'd then just need to pick the ones we need for each target like we did previously with the cmake files?
May 02 19:45:48 <Herrie> But I agree with Tofe it would make more sense to do this in machine.conf somehow
May 02 19:45:53 <Herrie> To have it centrally
May 02 20:12:30 <JaMa> well NYX_MODULES_REQUIRED is to select the right subset to build and then VIRTUAL-RUNTIME_nyx_modules_providers selects all providers of the modules (not the individual modules which should be installed)
May 02 20:31:26 <Herrie> JaMa: OK will give it a go tomorrow
**** ENDING LOGGING AT Thu May 03 03:00:05 2018