**** BEGIN LOGGING AT Fri Jun 29 03:00:00 2018
Jun 29 07:39:43 <Herrie|Laptop> Morning!
Jun 29 08:20:15 <JaMa> morning
Jun 29 08:20:56 <Tofe> Morning !
Jun 29 08:55:03 <Tofe> Herrie|Laptop: about the PR discusssion
Jun 29 08:55:22 <Tofe> Do you see what I mean by the "hook" idea for the setup ?
Jun 29 08:55:23 <Herrie|Laptop> Tofe: Yeah
Jun 29 08:55:30 <Herrie|Laptop> Not really
Jun 29 08:55:40 <Herrie|Laptop> Ah didn't see your last comment
Jun 29 08:55:41 <Herrie|Laptop> Let me check
Jun 29 08:56:50 <Herrie|Laptop> Tofe: We wouldn't need luneos_targets.xml anymore if we use halium-devices/setup
Jun 29 08:57:13 <Herrie|Laptop> We'd just need to upstream our device manifests to halium-devices (all are already except for Rosy)
Jun 29 08:57:44 <Herrie|Laptop> See https://github.com/Halium/halium-devices/tree/halium-7.1/manifests and https://github.com/Halium/halium-devices/tree/halium-5.1/manifests
Jun 29 08:57:50 <Herrie|Laptop> Already did those ;)
Jun 29 08:58:56 <Tofe> But still we need to remove hybris-boot and add the luneos_hal, isn't it?
Jun 29 09:00:06 <Herrie|Laptop> Tofe: luneos_hal we don't need
Jun 29 09:00:15 <Herrie|Laptop> Since setup script uses regexp magic to do that now
Jun 29 09:00:36 <Tofe> ah, we only used our patches for that
Jun 29 09:00:46 <Herrie|Laptop> Wallpaper for 5.1 for example: https://github.com/Halium/halium-devices/blob/halium-5.1/setup#L72
Jun 29 09:01:35 <Herrie|Laptop> And all the apk jar stuff in https://github.com/Halium/halium-devices/blob/halium-5.1/setup#L56
Jun 29 09:02:00 <Tofe> Why the [w][a][l][l][p][a][p][e][r] syntax ?
Jun 29 09:02:09 <Tofe> and not just wallpaper ?
Jun 29 09:03:49 <Herrie|Laptop> Just habit I have when writing regexps :P
Jun 29 09:03:53 <Herrie|Laptop> wallpaper could work too
Jun 29 09:03:59 <Herrie|Laptop> In this case
Jun 29 09:04:05 <Herrie|Laptop> Just try to be consistent
Jun 29 09:04:09 <Herrie|Laptop> In some other cases it wouldn't
Jun 29 09:04:58 <Tofe> so... we don't need luneos_hal, and hybris_boot maybe we could keep it actually (just ignore what it generates)
Jun 29 09:05:45 <Herrie|Laptop> There's also halium-boot now
Jun 29 09:05:56 <Herrie|Laptop> Tofe: Yeah in general we don't need luneos_hal anymore
Jun 29 09:06:01 <Herrie|Laptop> That was the whole point
Jun 29 09:06:18 <Tofe> Is there one scenario where we still need it ?
Jun 29 09:06:18 <Herrie|Laptop> So when vendor binaries update we don't have to rely on the shady patching that's prone for errors
Jun 29 09:06:34 <Herrie|Laptop> Tofe: Well there are some 7.1 targets that might need more regexps
Jun 29 09:06:42 <Herrie|Laptop> I.e. this doze/cmaction/lineageaction bits
Jun 29 09:06:46 <Herrie|Laptop> That's what I'll upstream still
Jun 29 09:06:51 <Herrie|Laptop> So far that's only Onyx it seems
Jun 29 09:07:15 <Tofe> For rosy I've patched the vendor repo, for the moment
Jun 29 09:08:01 <Tofe> what about these two ? https://github.com/webOS-ports/android_luneos_hal/tree/halium-5.1/patches/hardware/libhardware
Jun 29 09:14:42 <Herrie|Laptop> Rosy vendor should be OK
Jun 29 09:14:47 <Herrie|Laptop> The setup script should take care of this
Jun 29 09:14:54 <Herrie|Laptop> I tested this with a dozen or so devices
Jun 29 09:15:15 <Herrie|Laptop> From different manufacturers in halium-devices
Jun 29 09:17:39 <Herrie|Laptop> Tofe: Well this is actually a UB Ports issue
Jun 29 09:17:55 <Herrie|Laptop> That's why we need the patches
Jun 29 09:19:11 <Herrie|Laptop> For this I would suggest to keep our own fork and do a remove of the halium version and add ours without the last 2 commits from https://github.com/Halium/android_hardware_libhardware/commits/ubp-5.1
Jun 29 09:19:19 <Herrie|Laptop> That should only be for 5.1 and would only affect TP
Jun 29 09:20:20 <Herrie|Laptop> Since UB Ports assume all targets are AOSP I guess
Jun 29 09:32:30 <Tofe> yes
Jun 29 09:32:48 <Tofe> but I mean, this means we still need our local manifest
Jun 29 09:32:57 <Tofe> however we put
Jun 29 09:32:59 <Tofe> it
Jun 29 09:33:57 <Tofe> Though I'd prefer not forking that particular repo: we might miss important fixes from Halium even on 7.1
Jun 29 09:33:59 <Herrie|Laptop> Tofe: We can remove the repo that's added by https://github.com/Halium/android/blob/halium-5.1/default.xml#L140
Jun 29 09:34:14 <Herrie|Laptop> And add our fork
Jun 29 09:34:17 <Herrie|Laptop> Tofe: Well it's only for 5.1
Jun 29 09:35:06 <Tofe> yes, ok, why not. But it doesn't solve the initial question then :)
Jun 29 09:35:35 <Tofe> I'll discuss it with Halium guys a bit
Jun 29 09:35:55 <Herrie|Laptop> Well there are only a small number of 5.1 targets
Jun 29 09:36:13 <Herrie|Laptop> https://github.com/Halium/halium-devices/tree/halium-5.1/manifests
Jun 29 09:36:26 <Tofe> For 5.1 it's not a problem, I agree: it's pretty much old stuff now anyway
Jun 29 09:37:13 <Tofe> Most of the work today is on 7.1, and the edgy work is on 8.0
Jun 29 09:37:18 <Herrie|Laptop> Yup
Jun 29 09:38:39 <Tofe> So, in the end the question would be how to keep a minimal gap between our 5.1 build script and 7.1 one (which wouldn't even need our local manifest)
Jun 29 09:40:34 <Tofe> oh but wait: what about introducing this "remove hardware repo and replace it with a patched one" only in the touchpad manifest
Jun 29 09:41:51 <Tofe> Because, if I'm correct, it's really only about TP
Jun 29 09:47:23 <Herrie|Laptop> Tofe: Well it shouldn't matter for the others
Jun 29 09:47:31 <Herrie|Laptop> Since we don't set the flags during the build for those
Jun 29 09:47:52 <Herrie|Laptop> It's just that UB Ports until recently at least had no way to have CAF and non-CAF side by side
Jun 29 09:47:53 <Herrie|Laptop> And we do
Jun 29 09:48:03 <Herrie|Laptop> That's what they faced when they started to play with 7.1
Jun 29 09:53:12 <Herrie|Laptop> Tofe: We shouldn't have issues, because we build libhybris based on https://github.com/shr-distribution/meta-smartphone/blob/pyro/meta-hp/conf/machine/tenderloin.conf#L30
Jun 29 09:53:16 <Herrie|Laptop> Which is machine specific
Jun 29 09:53:26 <Herrie|Laptop> However UB Ports didn't have this option so they faced issues
Jun 29 09:53:30 <Herrie|Laptop> And needed AOSP
Jun 29 09:53:59 <Herrie|Laptop> So we should be OK to do the remove & add in default.xml for all 5.1 targets
Jun 29 11:19:40 <JaMa> will do another webOS OSE build on jenkins soon, this time it should work without the work arounds for qemux86
Jun 29 11:24:39 <Herrie|Laptop> JaMa: OK great
Jun 29 11:24:45 <Herrie|Laptop> I saw some new bits pushed a few hrs ago
Jun 29 12:16:53 <JaMa> Herrie|Laptop: nothing really interesting for us unfortunately
Jun 29 12:17:02 <Herrie|Laptop> JaMa: Yes saw that but well
Jun 29 12:17:18 <Herrie|Laptop> Seems some A1's will be in the mail shortly, got image ready to start testing
Jun 29 12:17:41 <Herrie|Laptop> Likely to fail, but Tofe got his Rosy behaving quite OK too already
Jun 29 12:17:48 <JaMa> did they ask for your address already?
Jun 29 12:17:52 <Herrie|Laptop> So we're making progress
Jun 29 12:17:55 <Herrie|Laptop> Yes last week
Jun 29 12:17:59 <Herrie|Laptop> Or early this week
Jun 29 12:18:03 <JaMa> aha, good
Jun 29 18:12:04 <Tofe> Herrie: https://github.com/Halium/halium-devices/pull/101
Jun 29 18:29:00 <Tofe> Herrie: could you push the https://github.com/Tofee/android_hardware_libhardware/tree/qcom-bsp-5.1  branch to our webos-ports account ? It's the same as upstream, without the two commits for AOSP headers
Jun 29 18:31:29 <Tofe> oooh but I just discovered that hp_tenderloin.xml already has what is needed for halium-devices.. silly me...
Jun 29 18:31:39 <Herrie> Tofe: We have cm12.1branch already
Jun 29 18:32:05 <Tofe> yes, sorry, I'm lagging behind tonight :)
Jun 29 18:33:21 <Tofe> Herrie: but then for 5.1 we can drop luneos_hal completely and start using halium's manifest + device/setup ?...
Jun 29 18:34:41 <Herrie|TP> Tofe: Yes :-)
Jun 29 18:34:58 <Tofe> ok, I'll change our build script then
Jun 29 18:35:07 <Herrie|TP> Small bits I was working on to make things a bit more smooth and easier to maintain
Jun 29 18:35:29 <Herrie|TP> Just you might want to force sync because otherwise repo will moan about locally changed files
Jun 29 18:35:48 <Herrie|TP> I.e. we might want to pass force-sync to setup script
Jun 29 18:36:08 <Tofe> doesn't the setup script do that already ?
Jun 29 18:36:13 <Herrie|TP> Repo sync options were added not too long ago
Jun 29 18:36:24 <Herrie|TP> Tofe: Not force sync I think
Jun 29 18:36:50 <Herrie|TP> I usually would just drop my device & vendor folders in between targets but that's nasty
Jun 29 18:37:40 <Herrie|TP> At least doesn't force sync by default but you can pass the command line params for repo now, if I recall correctly
Jun 29 18:48:44 <Tofe> ok, I think it's correct now
Jun 29 18:49:01 <Tofe> Herrie: it's too soon for doing the same for 7.1, right ?
Jun 29 18:49:29 <Herrie> https://github.com/Halium/halium-devices/blob/halium-7.1/README.md#L22
Jun 29 18:49:38 <Herrie> Tofe: Well all work except for Onyx really
Jun 29 18:50:41 <Herrie> I.e. I need to add some bits to setup script to deal with https://github.com/webOS-ports/android_luneos_hal/tree/halium-7.1/patches/device/oneplus/onyx
Jun 29 18:50:51 <Herrie> And https://github.com/webOS-ports/android_luneos_hal/tree/halium-7.1/patches/device/motorola/athene
Jun 29 18:51:06 <Herrie> So the various Doze variants, CMActions, LinegeActions that's about it
Jun 29 18:52:40 <Tofe> Doesn't look easy to automatize
Jun 29 18:56:27 <Tofe> for athene, there's a halium-7.1 branch which looks quite clean
Jun 29 18:57:31 <Herrie> Well got the regexps ready more or less just need find time to wrap up and test for soem targets
Jun 29 19:00:14 <Tofe> I have quite a hard time reading the [a][b][c][d] regexps... may I propose a PR for simplifying this ?
Jun 29 19:09:04 <Herrie> Tofe: I like them like that, but let the majority decide :P
Jun 29 19:17:08 <Tofe> https://github.com/Halium/halium-devices/pull/102 & 103
**** ENDING LOGGING AT Sat Jun 30 03:00:03 2018