**** BEGIN LOGGING AT Sun Jul 15 03:00:02 2018
Jul 15 06:49:23 <elvispre|s> Morning
Jul 15 07:14:09 <Herrie> Morning!
Jul 15 07:34:33 <elvispre|s> Herrie: How many of these halium patches should still apply? There are still seven of them in android_luneos_hal. Two for athene and the rest for onyx(/oppo).
Jul 15 07:35:08 <elvispre|s> I got the impression there was maybe only supposed to be one left. (For onyx system.prop.)
Jul 15 07:45:34 <Herrie> elvispre|s: Yes
Jul 15 07:45:41 <Herrie> But Halium-devices PR didn't get merged yet
Jul 15 07:45:49 <Herrie> Once it's merged it's only the system.prop still required
Jul 15 07:46:04 <elvispre|s> Cool! I can work around that.
Jul 15 07:46:16 <Herrie> You basically can use this: https://github.com/Herrie82/halium-devices/commit/b8eb919f77c2dcbce73c81c129bec616cd577dd4
Jul 15 07:46:58 <Herrie> And drop all other patches from android_luneos_hal
Jul 15 07:47:00 <Herrie> That should work
Jul 15 07:47:02 <elvispre|s> Oh, I already have :-)
Jul 15 07:47:04 <Herrie> I tested it for Athene
Jul 15 07:47:45 <elvispre|s> I already have... apart from dropping the extra patches, I mean
Jul 15 07:50:04 <Herrie> Just not sure what's up with Onyx tbh
Jul 15 07:50:13 <Herrie> With the audio_intermediate stuff
Jul 15 07:51:26 <elvispre|s> If I get that far, I'll see if I can figure that out.
Jul 15 07:56:20 <Tofe> Morning1
Jul 15 07:56:27 <Tofe> !
Jul 15 07:56:43 <Tofe> Herrie: your PR looks good :)
Jul 15 07:58:27 <Herrie> Tofe: Initially wanted to patch the .mk but that wouldn't suffice. This is a bit more radical but seems to work
Jul 15 10:18:38 * elvispre|s finally got to the halium build audiod problem and wonders how Herrie got rid of the oppo/common/keyhandler folder because my way is extremely crude
Jul 15 12:17:00 <Herrie|TP> elvispre: "rm -rf keyhandler" from the right directory. How did you fix the audiod issue?
Jul 15 14:39:44 <elvispre|s> Herrie: I haven't fixed it yet. It took me a while just to reach that problem. If you want a laugh check the last few commits here https://github.com/corpuscle/halium-devices/commits/halium-7.1
Jul 15 14:48:23 <Herrie> elvispre: Let me double check the onyx in a bit when little one wakes up, need to power on my builder ;)
Jul 15 15:08:01 <elvispre> Herrie: Got an onyx build!
Jul 15 15:08:14 <Herrie> Ok what was the trick?
Jul 15 15:08:33 <elvispre> I put the kernel source where it was expected to be :-)
Jul 15 15:09:13 <elvispre> Give me a minute and I'll post a few URLs...
Jul 15 15:11:25 <elvispre> My build script: https://pastebin.com/GFL9rFrV
Jul 15 15:12:03 <elvispre> Patch applied *after* the device folders have been synced. That helped.
Jul 15 15:12:51 <elvispre> See also https://github.com/corpuscle/android_luneos_hal/commits/halium-7.1
Jul 15 15:13:20 <elvispre> https://github.com/corpuscle/android/commits/luneos-halium-7.1 and
Jul 15 15:13:39 <elvispre> https://github.com/corpuscle/halium-devices/commits/halium-7.1
**** ENDING LOGGING AT Mon Jul 16 03:00:01 2018