**** BEGIN LOGGING AT Mon Jul 16 03:00:01 2018 Jul 16 12:16:27 Morning! Jul 16 12:16:49 elvispre: Seems you're right. My setup script only covers "commons" from the same manufacturer. So oneplus and oppo don't work Jul 16 12:17:06 I guess I need to add an exception for that one Jul 16 12:17:10 To also search oppo Jul 16 12:43:03 morning Jul 16 12:49:04 Tofe: ping Jul 16 13:42:37 Tofe: for record: https://codereview.qt-project.org/#/c/234639/ Jul 16 17:50:37 Morning! Jul 16 17:51:03 bshah: oh great ! :) Jul 16 18:11:47 Evening! Jul 16 18:12:36 Tofe: Morning! Jul 16 18:12:38 elvispre: Hi Jul 16 18:12:45 About oppo you're right Jul 16 18:12:52 I need to add an exception to setup script for that one Jul 16 18:12:56 BEcause it's a weird one :P Jul 16 18:13:03 I take $VENDOR/common Jul 16 18:13:07 But not oppo/common Jul 16 18:14:22 Yeah, I could see it was something like that. But I just wanted to get it working so I didn't try to generalise at all. Jul 16 18:14:51 oppo isn't the vendor in your case? Jul 16 18:15:13 ah, or, there is a linebreak or something like that isn't it Jul 16 18:15:46 The kernel source code folder location was a weird one. I don't know why the original (msm9667? something like that) ever worked before. Jul 16 18:17:20 Tofe: oppo is the ancestor project / parent company of OnePlus I believe. So the OnePlus/onyx relies on some code in oppo/common. (Something like that.) Jul 16 18:17:51 ah, ok, that's a tricky one Jul 16 18:18:06 * elvispre is saying "something like that" way too much already! Jul 16 18:19:03 :) Jul 16 18:30:13 Well there's also: https://github.com/lineageos/android_device_oneplus_common Jul 16 18:30:25 I'm not sure why that isn't used instead of https://github.com/lineageos/android_device_oppo_common Jul 16 18:30:52 Seems they started to use the OnePlus variant with OP3 Jul 16 18:30:53 they like setting up traps Jul 16 18:34:27 Well I still don't have sensors or Bluetooth so it might be good to have some options. Jul 16 18:36:10 elvispre: It could be I pr-ed wrong kernel in manifest Jul 16 18:36:57 Herrie: I am just using the LineageOS kernel locally (and in those links I posted). Jul 16 18:37:19 Seems so: https://github.com/webOS-ports/android/blob/11d6ae22e467adce12f960565e3dc5e8729420b9/luneos_targets.xml#L41 Jul 16 18:37:45 I thought Halium were using an old copy of the LineageOS kernel so I was kind of surprised to see your LuneOS one there. Jul 16 18:38:24 I PR-ed the Onyx manifest to Halium-devices ;) Jul 16 18:38:29 I just need to update it Jul 16 18:38:44 Halium should be OK with LineageOS kernel, just we aren't and we need updated defconfig anyway Jul 16 18:38:52 So 1:1 LineageOS doesn't work Jul 16 18:38:57 Unless we upstream the defconfig Jul 16 18:41:05 My current approach is to build Halium with an up to date LineageOS kernel and to start from there for LuneOS. Jul 16 18:42:20 This is what I'm using for LuneOS currently: https://github.com/corpuscle/android_kernel_oneplus_onyx/tree/luneos/cm-14.1-wip Jul 16 18:43:11 It should look pretty familiar except that I have left the LineageOS defconfig alone and created a LuneOS variant. Jul 16 18:52:39 I would be surprised if there's a whole lot of activity in the LOS 14.1 kernel tree tbh Jul 16 18:55:34 Oh there isn't. The cm-15.0 one is all but identical to it as well. Jul 16 18:56:19 s/cm-15/lineage-15 **** ENDING LOGGING AT Tue Jul 17 03:00:03 2018