**** BEGIN LOGGING AT Sat Apr 30 02:59:56 2022 Apr 30 06:02:09 Morning! Apr 30 06:02:16 Herrie: I pushed the patch Apr 30 06:30:49 Tofe: Morning! I have a bunch of patches too, went to bed way too late as a result :P Apr 30 06:31:08 Will push them later today after some coffee Apr 30 06:31:19 Mainly to sort some issues in logs Apr 30 06:31:52 Not much actual fixing except for Universal Search showing apps in it's results Apr 30 06:59:44 Tofe: Well here we go: https://github.com/webOS-ports/luna-universalsearchmgr/pull/15, https://github.com/webOS-ports/lumberjack/pull/3, https://github.com/webOS-ports/luna-systemui/pull/19, https://github.com/webOS-ports/luna-appmanager/pull/36, https://github.com/webOS-ports/luna-surfacemanager/pull/2, https://github.com/webOS-ports/webos-keyboard/pull/92, https://github.com/webOS-por Apr 30 06:59:44 ts/ime-manager/pull/1, https://github.com/webOS-ports/bootd/pull/6 and https://github.com/webOS-ports/wam/pull/5 Apr 30 07:04:37 Got impatient, so you have some more time for review LOL Apr 30 10:04:29 Wow 🙂👍 Apr 30 10:05:39 I'm visiting some wine domains today, so I'll see when I get some time to review; at first sight lgtm though Apr 30 10:29:43 Tofe: Nice! Apr 30 10:30:00 Yeah I'm just going through logs and trying to kill obvious errors for now Apr 30 10:30:06 Never hurts usually Apr 30 10:30:13 At least removes some of the noise Apr 30 22:13:49 Tofe: For when you have a minute: I'm seeing this in logs: 2022-04-30T20:43:01.568471Z [6.905827031] user.warning LunaSysMgr[419] static bool SuspendBlockerBase::cbIdentify(LSHandle*, LSMessage*, void*): 248 Failed to subscribe to powerd {"returnValue":false,"errorCode":-1,"errorText":"Denied method call \"identify\" for category \"/com/palm/power\""} Apr 30 22:14:11 Traced it back to this bit in the code: https://github.com/webOS-ports/luna-sysmgr/blob/webOS-ports/master/Src/base/SuspendBlocker.cpp#L246 Apr 30 22:15:07 When I manually call this: https://github.com/webOS-ports/luna-sysmgr/blob/webOS-ports/master/Src/base/SuspendBlocker.cpp#L210-L211 I get a reply Apr 30 22:16:30 I suspect the check for !clientId in L246 might be incorrect since it's a "const char *" that's set to 0 intitially. So I'm not sure if this check for !clientId is actually a valid check? https://github.com/webOS-ports/luna-sysmgr/blob/webOS-ports/master/Src/base/SuspendBlocker.cpp#L236 Apr 30 22:50:19 Herrie: one possibility here is that clientId doesn't exist or isn't a string Apr 30 22:51:02 ah no wait, the issue is earlier Apr 30 22:52:02 we should check that LunaSysMgr does have the rights to call identify Apr 30 22:52:28 Tofe: OK Apr 30 22:52:38 Well a bit tired now, pushed a few more PR's today for review Apr 30 22:52:51 Once they are all reviewed and merged will do a rebuild and see what's left Apr 30 22:54:23 BTW while debugging I ran into some things in the logs where WAM is available a bit too early. Seems we might be able to fix that by: https://github.com/webosose/webos-initscripts/commit/4c5d00438974c6dbb42448442bc33085e5677b1e Apr 30 22:56:00 Seems both WAM and Maliit are started too early and that gives some errors in logs Apr 30 22:56:57 Don't we already have that lsm-ready check ? TBC tomorrow :) Apr 30 22:57:03 gn8 ! Apr 30 22:57:24 Tofe: Well by the looks of the logs not ;) Apr 30 22:57:27 Anyway gn8 Apr 30 22:57:30 Bedtime here too Apr 30 22:57:50 This one looks interesting: https://github.com/webosose/webos-initscripts/blob/master/files/systemd/services/common/lsm-ready.service **** ENDING LOGGING AT Sun May 01 02:59:56 2022