**** BEGIN LOGGING AT Sun May 01 02:59:56 2022 May 01 06:23:17 morning May 01 08:14:00 Morning! May 01 10:48:14 Morning! May 01 10:49:50 Herrie: I don't really want to have that kind of crappy service, if possible; starting a systemd service from ExecStart inside another service is just bad May 01 10:58:40 Tofe: OK understandable. I just saw that they used this as a "workaround" for WAM and Maliit by the looks of it May 01 11:02:44 But I guess there are other ways to achieve this. Seems we need to wait for lsm-ready signal and then start them May 01 11:19:20 Tofe: By the way I noticed that notificationmgr gets killed automatically somehow May 01 11:19:35 Even though we seem to have the correct bits in systemd? May 01 11:21:15 https://github.com/webOS-ports/notificationmgr/blob/webOS-ports/webOS-OSE/files/systemd/notificationmgr.service#L31-L32 May 01 11:27:35 well, we can use the path condition or something like that to test lsm-ready ; I thought we already did that, actually May 01 11:27:59 for notificationmgr, I don't know, but we'd have to see why it is kill/crashed May 01 11:33:01 Tofe: There are still a number of PR's pending. Not sure you got notification for all of them May 01 11:33:17 Sometimes at my end emails from GH don't always arrive May 01 11:43:04 Tofe: https://github.com/webOS-ports/notificationmgr/pull/1, https://github.com/webOS-ports/luna-service2-security-conf/pull/5, https://github.com/webOS-ports/wam/pull/5/files, https://github.com/webOS-ports/bootd/pull/6/files, https://github.com/webOS-ports/ime-manager/pull/1, https://github.com/webOS-ports/sam/pull/6 and https://github.com/webOS-ports/luna-surfacemanager/pull/2/files May 01 11:43:05 I see here still May 01 11:45:27 ah, let me see :) May 01 11:46:59 it's strange I didn't see the corresponding mails May 01 11:47:18 I thought at first that was because I didn't have write access, but I do have it May 01 11:48:00 Tofe: Yeah I have that sometimes too, emails don't show up May 01 11:50:05 the one for "com.webos.serivce.ime.role.json.in: Add org.maliit" is quite surprising: how does the vkbd work in OSE?... May 01 11:50:21 Tofe: Well I'm not sure if that one is 100% needed now May 01 11:50:21 But I agree with the PR anyway May 01 11:50:32 well, I always saw the warning May 01 11:50:37 I guess the issue might have come from the files that were shipped by webos-keyboard which I now removed May 01 11:51:00 I.e.: https://github.com/webOS-ports/webos-keyboard/commit/c89d6d2918d732860b38408c9bfeb5da87bb17d8 May 01 11:51:53 I had so many changes in my build it's hard to test them one by one at the time sometimes May 01 11:53:15 :) May 01 11:53:23 Tofe: I also noticed in logs we don't have https://github.com/webosose/com.webos.service.memorymanager yet. Not sure if we want this? May 01 11:53:33 but the service rights are better in imemanager side anyway May 01 11:54:01 well, for that one we'll see a bit later, not sure how it'll behave on our devices May 01 11:54:12 let's just stabilize our build first May 01 11:54:59 Tofe: OK May 01 11:55:00 Makes sense May 01 11:55:01 https://github.com/webOS-ports/sam/blob/webOS-ports/webOS-OSE/src/bus/service/ApplicationManager.cpp#L150= here I don't really know what LG plans to do: only keep com.webos.applicationManager ? it would be weird, as only com.webos.service.applicationManager appears in their public documentation May 01 11:55:24 anyway, let's just support both for the moment May 01 11:55:50 Tofe: Well they have https://github.com/webOS-ports/sam/blob/webOS-ports/webOS-OSE/src/bus/service/ApplicationManager.cpp#L152-L153 May 01 11:56:16 Tofe: Yeah I'm also not sure, I'm just trying to kill as many warnings and errors as I can in the logs to get some of the noise out May 01 11:56:24 And we can focus on the important things May 01 11:56:31 Some where there from before migration already May 01 11:56:32 yes, but https://github.com/webOS-ports/sam/blob/webOS-ports/webOS-OSE/src/bus/service/ApplicationManager.h#L165= May 01 11:57:16 but it's not really a big concern right now, I could bet that this will stay for a couple of years still at least :) May 01 11:58:51 so, let's not forget we still have to sort out the issue with WEBOS_WINDOW_BASE_GEOMETRY (i.e. where/how do we set it correctly?) May 01 12:00:17 ^ I think the most easy way, for now, would be to set "WEBOS_DEVICE_PIXEL_RATIO=1.0" instead of "auto" May 01 12:02:59 Tofe: Well it should get it from the geometry automatically according to: https://github.com/webosose/qtwayland-webos/blob/e0b297269bda7fc4a5a5eb99e6f3a973bb45043d/src/plugins/platforms/webos-wayland-egl/webosscreen.cpp#L39 May 01 12:03:28 Unless the code there doesn't do it's job properly May 01 12:04:13 the thing is, I don't really know when this kind of scaling does work May 01 12:04:45 why not just adapt the size of the qml app ? May 01 12:06:03 to me, it's like they developped everything for 1080p, and then adapt to other screens (4K or automotive tablets) just by scalling it all May 01 12:07:02 for instance, the scaling only works if the form factor stays exactly the same May 01 12:07:51 Tofe: Ah OK May 01 12:07:55 Yeah well could make sense May 01 12:08:05 I guess everything is 1920x1080 or a multiple in their case May 01 12:08:13 yes, probably May 01 12:08:39 so I agree it would be nice to set a correct geometry env value, but it much easier to setup the ratio ;) May 01 12:09:37 another way is to *not* set the base_geometry variable May 01 12:09:46 then the code fallbacks to a 1.0 ratio May 01 12:10:03 yes, that's cleaner, I'll do that May 01 12:12:22 I'll put that in lsm-rebase branch May 01 12:13:37 done May 01 12:16:43 Herrie: I propose we merge your lsm-rebase branch, and then bump all that's needed May 01 12:21:06 Well I already added everything May 01 12:21:13 Let me do a quick build to test and will PR to honister May 01 12:21:29 ok ! May 01 12:22:34 Shouldn't be long since I have most changes already locally I guess May 01 12:22:55 I'm updating my PP build too May 01 12:23:11 I'll be away next week, but I bring my PP :) May 01 12:24:20 Tofe: I noticed that notifications don't work at all at my end, but could have been my build somehow May 01 12:24:25 Let me retest with this new build May 01 12:24:28 Tofe: Anywhere nice? May 01 12:25:05 Herrie: a bit like last year, we spend a week in Brittany, on the western coast May 01 12:25:37 should be nice yes :) May 01 12:26:02 OK it's building rootfs, so I guess recipes are all good to PR May 01 12:27:07 yep May 01 12:28:04 I think the last big thing to tackle is maliit May 01 12:28:23 Tofe: Well we should be close really May 01 12:28:30 I think so too May 01 12:28:37 I even got it running once :p May 01 12:28:40 And then it's small things like notifications that aren't working OK yet May 01 12:28:42 https://github.com/webOS-ports/luna-surfacemanager/pull/3 May 01 12:30:43 And this one: https://github.com/webOS-ports/luna-sysmgr/pull/44 May 01 12:37:11 There we go: https://github.com/webOS-ports/meta-webos-ports/pull/520/files May 01 12:39:31 All good for me ! merged May 01 12:45:35 ok, my newly flashed PP is behaving ok May 01 12:45:55 Tofe: Well that's good May 01 12:46:08 just no keyboard, and post-firstuse isn't perfect (the launcher doesn't show) but the rest is fine May 01 12:46:36 Tofe: Nice! May 01 12:46:47 Testing Qemu here in a minute too May 01 12:47:28 ah, I'd gladly download your qemu image before I go tomorrow May 01 12:48:30 Let me push it May 01 12:52:07 Tofe: luneos-dev-emulator-qemux86-64-20220105.tar.gz May 01 12:55:04 Seems I broke IME manager May 01 12:55:05 Let me fix it May 01 12:57:31 Will right away have the chance to test the org.maliit requirement or not May 01 12:58:53 OK seems we need org.maliit ;) May 01 12:58:54 May 01 13:57:27 qemux86-64 ls-hubd[235]: [] [pmlog] ls-hubd LSHUB_NO_NAME_PERMS {"APP_ID":"org.maliit","ROLE_ID":"/usr/sbin/MaliitServer","EXE":"/usr/sbin/MaliitServer"} Executable: "/usr/sbin/MaliitServer" (cmdline: /usr/sbin/MaliitServer -instance 0) does not have permission to register name: "org.maliit" May 01 12:58:54 May 01 13:57:27 qemux86-64 MaliitServer[807]: [] [pmlog] LS_REQ_NAME {"FILE":"transport.c","LINE":1931} Invalid permissions for org.maliit May 01 13:06:32 isn't this exactly what you fixed ? May 01 13:09:10 Herrie: https://github.com/webOS-ports/ime-manager/blob/6abc4b1e543263211bc2dba85d3128db240cc294/service/com.webos.service.ime.role.json.in#L4= here, missing \ before a quote May 01 13:10:39 OK this one: https://github.com/webOS-ports/ime-manager/commit/e71b9c458e4aa9203991ba84eed7104306372ce3 May 01 13:10:44 Tofe: Yeah May 01 13:10:51 Well I forgot 1 part it seems as well May 01 13:14:38 OK: https://github.com/webOS-ports/meta-webos-ports/commit/85757beded46cb3689c376cb04b0f2a15fec0047 May 01 13:14:42 That should fix it May 01 13:15:56 And also bring back the QML Settings apps May 01 13:23:06 good ! May 01 13:44:09 Tofe: OK put it there too luneos-dev-emulator-qemux86-64-20220105-new.tar.gz May 01 14:12:42 thanks ! I got it May 01 15:29:27 Tofe: My HW KBD doens't work in this image May 01 15:29:35 When I break imemanager it seems to work ;) May 01 15:29:40 Or at least it did before May 01 15:30:44 it might be that maliit is half-taking over May 01 15:42:32 Seems so May 01 15:47:51 Tofe: I noticed there are quite a few preference calls failing in the logs. They seem to originate from here: https://github.com/webOS-ports/luna-sysmgr-common/blob/webOS-ports/master/Src/base/settings/Preferences.cpp May 01 15:48:36 I.e.: https://github.com/webOS-ports/luna-sysmgr-common/blob/webOS-ports/master/Src/base/settings/Preferences.cpp#L414 May 01 15:49:11 Seems it gets "null" as caller somehow which I guess is the issue: "[ 703] 770.232 TX call 6 (null) (8CxPISCo) com.palm.systemservice (dPAqG238) (null) //getPreferences" <- that's from ls-monitor May 01 15:50:29 Seems about 15 calls that aren't not working due to this May 01 16:01:57 Maybe this will work? I will test it: https://github.com/webOS-ports/luna-sysmgr-common/commit/55664d19d4f305720380d96c7808e2adf56c7c42 May 01 16:04:02 Tofe: I also still noticed the permission issues for qml-runner with our qml apps May 01 16:06:43 Herrie: you're probably on the right track, yes May 01 16:06:52 empty names aren't supported anymore May 01 16:07:36 It seems we might have a few more of those cases May 01 16:07:59 Easy enough to fix in general though May 01 16:19:11 And now it's stuck on boot logo May 01 16:19:25 Seems that the calls somehow succeed but now UI LSM doesn't show up :S May 01 16:20:20 that's a bit unexpected May 01 16:21:09 Seems lunasysmgr doesn't start now May 01 16:21:17 I guess my name choice might have been problematic? May 01 16:21:21 ah, but wait, with your commit you're going to get a conflict May 01 16:21:36 you can't register the same name twice May 01 16:22:10 I see this now: May 01 15:15:27 qemux86-64 ls-hubd[235]: [] [pmlog] ls-hubd LSHUB_NO_NAME_PERMS {"APP_ID":"com.palm.systemmanager","ROLE_ID":"/usr/sbin/LunaAppManager","EXE":"/usr/sbin/LunaAppManager"} Executable: "/usr/sbin/LunaAppManager" (cmdline: /usr/sbin/LunaAppManager) does not have permission to register name: "com.palm.systemmanager" May 01 16:22:56 that's also possible, if the name wasn't declared before May 01 16:23:14 which is probably the case, otherwise it would be already registered May 01 16:23:50 I think the reason we used NULL here is that we are in a "common" source code, probably used by several apps May 01 16:25:06 not sure it's still the case though May 01 16:25:18 in OpenWebOS, it was used in luna-sysmgr and in webappmanager May 01 16:25:36 so we probably still use it in luna-sysmgr, but pretty sure that WAM doesn't :) May 01 16:26:50 which means you can use "com.palm.systemmanager-prefs" and "com.palm.systemmanager-localeprefs" as names, and adapt the ls2 files to authorize it May 01 16:27:35 the correct final solution here would be to merge common into luna-sysmgr May 01 16:27:47 but that's for another day May 01 16:28:18 Tofe: OK that's what I was about to try May 01 16:28:35 The things is that morphis at some point spun it out from luna-sysmgr it seems May 01 16:28:51 right May 01 16:29:02 https://github.com/webOS-ports/luna-sysmgr-common/commit/c6c6d9d7e453f820caa1da3cf1570f345e89548a May 01 16:29:56 therefore the question becomes: what DEPENDS on luna-sysmgr-common May 01 16:30:49 luna-next, luna-qml-launcher, mediaindexer May 01 16:31:50 sensorfw and luna-appmanager too it seems May 01 16:31:55 Well some of those are gone now ;) May 01 16:32:25 I wonder which of these uses Preferences and LocalePreferences May 01 17:19:58 Well seems LocalePreferences now remains in luna-appmanager at least: https://github.com/search?l=C%2B%2B&q=org%3AwebOS-ports++LocalePreferences&type=Code May 01 17:20:17 So we could move it there as well or migrate remaining bits from luna-appmanager back to luna-sysmgr at some point May 01 17:43:25 Well if there are things used from common a bit all over the place, let's keep it that way May 01 17:44:26 I'll put in place a way get the ls2 handle in a cleaner way a bit later May 01 17:50:45 Ah now I run into duplicate registration issue, seems both luna-appmanager and luna-sysmgr try to do it May 01 17:52:33 ah, ok, then I guess I need to step in May 01 17:54:07 I guess if we pass in the caller somehow it would help May 01 17:54:21 So we could register it twice, though with an unique name, but that's also quite nasty I guess May 01 17:54:23 yes, I'll sketch something up May 01 18:00:09 Herrie: may I manipulate your branch? May 01 18:00:33 Tofe: Sure May 01 18:00:42 It was anyway WIP May 01 18:01:03 ok May 01 18:06:23 Herrie: ok I pushed a variant May 01 18:06:43 just authorize "com.palm.systemmanager-*" where needed May 01 18:13:39 Also, I didn't do it myself, but it would be better to merge the 3 "fix" commits May 01 18:18:30 Tofe: OK done May 01 18:18:33 Let me test May 01 19:06:15 Tofe: OK get UI after your patch + permissions May 01 19:06:17 Let me check logs May 01 19:07:40 Hmmz still have some errors in logs May 01 19:07:47 Let me put kids to bed so I can check in more detials May 01 19:27:49 Seems I had this one pending still locally: https://github.com/webOS-ports/luna-appmanager/pull/37 May 01 19:30:28 OK errors are gone. Let me PR that as well May 01 19:31:57 great May 01 19:33:54 There are a few more with similar errors but I know how to fix those now ;) May 01 19:38:02 https://github.com/webOS-ports/luna-sysmgr/pull/45, https://github.com/webOS-ports/luna-sysmgr-common/pull/13 May 01 19:39:16 merged, thanks ! May 01 20:29:15 Tofe: And 1 more: https://github.com/webOS-ports/luna-appmanager/pull/38 May 01 20:29:26 I thought I pushed it before you merged, but seems you beat me with a few seconds ;) May 01 20:44:03 merged too :) May 01 20:50:03 And another small one: https://github.com/webOS-ports/luna-applauncher/pull/12 May 01 20:50:09 Seems I forgot to update the calls to SAM there May 01 20:56:53 Thanks, that's a nice set of patches for the week-end ! May 01 20:57:34 Tofe: Yeah not too bad, I have a few more coming, with similar fixes May 01 20:58:03 They probably don't fix a lot of issues in the end (though I hope it will fix the display issue in the end that we've been having for a while) May 01 20:58:11 I suspect it's one of those calls that cause havoc May 01 20:58:20 I mean where the display goes off even when used May 01 21:21:07 OK another one for keymanager: https://github.com/webOS-ports/luna-sysmgr/pull/46 and https://github.com/webOS-ports/luna-next-cardshell/pull/333 May 01 21:37:42 oh, launchPointChanges doesn't exist in SAM ? May 01 21:38:29 Tofe: no May 01 21:38:40 There is something that does something similar I think, but it has different API May 01 21:38:48 Let me update that PR for sysmgr May 01 21:39:57 Tofe: OK done May 01 21:40:31 There is a "updateLaunchPoint" May 01 21:44:26 Seems what launchPointChanges did might now be done by "listLaunchPoints" when I see https://www.webosose.org/docs/reference/ls2-api/com-webos-service-applicationmanager/#listlaunchpoints and https://github.com/webOS-ports/sam/blob/webOS-ports/webOS-OSE/files/schema/applicationManager.listLaunchPoints.schema#L7 May 01 21:50:49 ah, yes, with a subscribtion... well, let's switch to that when we have the working code, in the meantime I'll merge the current PR May 01 23:38:01 Tofe: Uploading luneos-dev-emulator-qemux86-64-20220502.tar.gz with all the latest merged changes included. Should be there in a minute **** ENDING LOGGING AT Mon May 02 02:59:57 2022