**** BEGIN LOGGING AT Thu Dec 15 02:59:56 2022 Dec 15 08:43:46 JaMa: Any thoughts on https://github.com/webosose/connman-webos vs connman from upstream? Dec 15 09:42:57 Seems it's just some patches on top of upstream 1.41 release used in Kirkstone, so I guess switching isn't causing a lot of harm, but will give some benefits Dec 15 10:04:43 Morning! Dec 15 10:06:18 Herrie: it's likely I won't have that much time to investigate the "proxy" acg thing, so maybe it's best I merge your PR in the meantime Dec 15 10:07:31 Tofe: OK well the PR improves things a bit, but I still have proxied calls failing and not sure what permissions to add to get them working Dec 15 10:07:42 I.e. to add a contact in Contacts app I still get issues Dec 15 10:08:18 Ok Dec 15 10:08:20 I.e.: Dec 14 15:29:59 qemux86-64 sam[662]: [] [pmlog] LS_REQUIRES_SECURITY {"SERVICE":"com.palm.app.calendar_com.webos.service.activitymanager_proxy","CATEGORY":"/","METHOD":"launch"} Service security groups don't allow method call. Dec 15 10:08:49 Notice the "funny" service name Dec 15 10:08:54 And there are a few of those Dec 15 10:09:35 For connman I think I'll just pull the patches from connman-webos and add those in our repo instead of using LG's fork for now Dec 15 10:10:29 I wonder who creates the app_manager_proxy kind of call id Dec 15 10:10:36 Tofe_: Yeah me too Dec 15 10:11:15 Or maybe it's the activity manager? Dec 15 10:11:36 I guess this commit or a related one: https://github.com/webosose/activitymanager/commit/dbd4cc56adee19586bfe8b3a7428193775c96261 Dec 15 10:12:40 Might be useful to add some more logging to activitymanager to see what's going on Dec 15 10:12:57 Looks related yes Dec 15 10:13:07 There's this in ls2: https://github.com/webosose/luna-service2/commit/8976237855f44852d2cb26e83adace0154f3266f Dec 15 10:16:34 Just the documentation is lacking here, so it's hard to understand what they're trying to do Dec 15 10:22:09 Herrie: yes it's just couple patches which used to be applied as .patch file and rebased by me to apply on 1.41, now it will be stuck on 1.41 for who knows how long and won't receive even security fixes from oe-core updates Dec 15 10:22:42 JaMa: OK, seems Patch 6 is already failing due to CVE patch upstream Dec 15 10:22:44 Will try to fix that Dec 15 10:22:57 https://github.com/webosose/meta-webosose/commits/master/meta-webos/recipes-connectivity/connman Dec 15 10:23:48 what is Patch 6? Dec 15 10:24:23 This one once I did format-patch on the repo: https://github.com/webosose/connman-webos/commit/c6dff02b993229219f53b75e1bebefa4e214e467 Dec 15 10:25:44 create a branch with patches applied in oe-core, then rebase ose patches on top of that and then use format-patch Dec 15 10:25:58 that's how I'm updating patches in most cases Dec 15 10:26:42 JaMa: That's what I'll be doing :P Dec 15 10:26:52 Seems it's the only one of the 10 so not that bad Dec 15 12:51:49 Herrie: good find for the ls2 proxy implementation, I think I begin to understand it Dec 15 12:52:35 so a new json is added, where you can declare what id/exename a given service can proxy for Dec 15 12:54:29 Tofe_: Well there is an example for activitymanager Dec 15 12:54:40 https://github.com/webosose/activitymanager/blob/master/files/sysbus/com.webos.service.activitymanager.proxy-agent.json.in Dec 15 12:55:18 and it's present in our image, right? Dec 15 12:55:22 I can check that Dec 15 12:55:39 Tofe_: Yeah it should be Dec 15 12:56:08 Tofe: I posted a recent image on GitHub if needed Dec 15 12:56:14 That has all the PR-ed fixes almost ;) Dec 15 12:56:31 yes it's there Dec 15 12:56:37 yes, I'm using it right now Dec 15 12:56:51 https://github.com/webOS-ports/luneos-testing/releases/tag/20221214-LuneOS-Testing-Builds Dec 15 12:58:00 ok we still see an error like [pmlog] LS_REQUIRES_SECURITY {"SERVICE":"com.palm.app.calendar_com.webos.service.activitymanager_proxy","CATEGORY":"/","METHOD":"launch"} Service security groups don't allow method call Dec 15 12:58:15 I was worried you already fixed all of them :) Dec 15 12:59:07 Tofe_: Yeah those I don't know how to solve Dec 15 12:59:14 For the rest it should be pretty OK Dec 15 12:59:20 Found one this morning in system menu ;) Dec 15 12:59:25 But otherwise most should be gone Dec 15 12:59:40 There are 2 in logs that don't have an ID so those need addressing as well Dec 15 13:00:17 looks like it's about service.calendar.reminders Dec 15 13:01:40 Yes, if you try to add a Contact in Contacts app, you get some more Dec 15 13:03:11 mmh the group "com.palm.service.calendar.reminders" seem to be alright on both sides Dec 15 13:04:16 ah, on app side it's qbout "com.palm.app.calendar-*" Dec 15 13:04:31 but the -* isn't in the error we see in the logs Dec 15 13:05:46 so it might be a little problem with the app id, when used through a proxy Dec 15 13:06:11 I'll change the permission to com.palm.app.calendar* and see Dec 15 13:07:55 I seem to have one less error Dec 15 13:08:17 but I still get sam[476]: [] [pmlog] LS_REQUIRES_SECURITY {"SERVICE":"com.palm.app.calendar_com.webos.service.activitymanager_proxy","CATEGORY":"/","METHOD":"launch"} Service security groups don't allow method call Dec 15 13:08:35 so a problem with SAM, now Dec 15 13:11:04 Tofe_: You need application.launcher there: https://github.com/webosose/sam/blob/master/files/sysbus/com.webos.sam.api.json#L45-L46 Dec 15 13:11:52 Seems that's missing Dec 15 13:12:05 https://github.com/webOS-ports/core-apps/blob/herrie/enhanced-acg/com.palm.app.calendar/appinfo.json#L45 Dec 15 13:18:14 I now get different erros Dec 15 13:18:16 errors Dec 15 13:18:37 ec 15 08:17:06 qemux86-64 surface-manager[535]: [] [pmlog] surface-manager LSM {} (null), : appId is undefined. Adding an object with a undefined member does not create a role for it. Dec 15 13:18:38 Dec 15 08:17:06 qemux86-64 sam[579]: [I][ApplicationManager][onAPICalled][APIRequest] API(/launch) Sender(com.palm.app.calendar_com.webos.service.activitymanager_proxy) Dec 15 13:18:38 D Dec 15 13:18:55 Well the 1st one I've seen before Dec 15 13:18:59 We have quite some of it I think Dec 15 13:19:21 ok, so maybe there's actually no new errors Dec 15 13:20:03 how do I know if my patch worked... maybe there should now be a calendar app started Dec 15 13:20:27 Tofe_: Yeah that would briefly give me something before but not show anything on screen Dec 15 13:20:43 You could apply the same patch for Contacts Linker and see if you cna create a contact Dec 15 13:20:57 currently I'm just debugging the errors during boot, I'm not doing any action Dec 15 13:21:44 Tofe_: Ah OK Dec 15 13:22:40 service.contacts.linker[1051]: [] [pmlog] LS_REQUIRES_SECURITY {"SERVICE":"com.palm.service.contacts.linker_com.webos.service.activitymanager_proxy","CATEGORY":"/","METHOD":"dbUpdatedRelinkChanges"} Service security groups don't allow method call. Dec 15 13:22:43 this error ? Dec 15 13:23:10 Yes Dec 15 13:27:04 Tofe: Ah might be simply need to add "contactslinkerservice.operation" to https://github.com/webOS-ports/app-services/blob/herrie/enhanced-acg/com.palm.service.contacts.linker/files/sysbus/com.palm.service.contacts.linker.perm.json ? Dec 15 13:28:49 oh, there seem to be a typo Dec 15 13:28:56 -service against just service Dec 15 13:30:21 same for contacts-service.operation Dec 15 13:31:09 still not enough Dec 15 13:31:56 I still get service.contacts.linker[647]: [] [pmlog] LS_REQUIRES_SECURITY {"SERVICE":"com.palm.service.contacts.linker_com.webos.service.activitymanager_proxy","CATEGORY":"/","METHOD":"dbUpdatedRelinkChanges"} Service security groups don't allow method call. Dec 15 13:32:24 btw, the name "service.contacts.linker" is weird Dec 15 13:32:42 why isn't there any com.palm prefix here Dec 15 13:49:07 Tofe_: Well I needed to come up with acg naming in json files myself for our services, could be I wasn't 100% consistent or got a typo somewhere Dec 15 13:49:25 In the train now, let me get out notebook after next stop Dec 15 13:51:48 I'm in the train too, not fully efficient either :) Dec 15 13:52:25 but mainly I wonder where the name comes from; I don't see it anywhere in our ls2 files Dec 15 13:52:34 or in the app itself Dec 15 13:56:01 Tofe_: I get contacts now and some more errors in logs Dec 15 13:56:21 Seems I just needed to give contact linker some more permissions Dec 15 13:56:29 The log message is a bit misleading though Dec 15 13:56:31 ok, good Dec 15 13:57:06 but you can add a contact? Dec 15 13:58:17 Yes Dec 15 13:58:24 After reboot it started to show up Dec 15 13:58:31 ok, that's great Dec 15 13:58:32 I have a few more issues in the logs, but know how to solve those now Dec 15 14:03:11 something I'll try to fix is when we close first use, the cardview status is a bit broken Dec 15 14:03:29 must be a qml issue somewhere Dec 15 14:07:14 Tofe_: Yeah when I maximize and swipe it away it seems to behave OK Dec 15 14:07:29 So it's the call to quit the app that somehow doesn't work with the button I'd say Dec 15 14:08:09 I'd say: https://github.com/webOS-ports/org.webosports.app.firstuse/blob/master/qml/main.qml#L68 Dec 15 14:08:19 Also I noticed LSM crashing quite some times after swiping away some apps Dec 15 14:08:28 And Phone app doesn't start LuneOS.Application not found Dec 15 14:08:43 Just a few things I noticed in terms of "low hanging fruits" Dec 15 14:08:57 Which might be easy to fix or not :P Dec 15 14:11:41 Tofe: LSM crashing is mainly with webApps I noticed Dec 15 14:12:42 Or a combination of QML & WebApps Dec 15 14:17:10 ok, closing of firstuse fixed, it was just a qml issue in cardshell Dec 15 14:21:11 https://github.com/webOS-ports/luna-next-cardshell/pull/335 Dec 15 15:15:32 Tofe: Ah nice & easy fix, those are good :D Dec 15 15:17:13 Merged Dec 15 16:42:57 Tofe: Hmmz FirstUse now starts carded for me, that's not good ? Dec 15 16:48:32 Tofe: Wait, seem might be user error here Dec 15 16:49:55 Seems to work OK Dec 15 16:51:21 BTW with OSE connman seems I do get a correct "internet connection" again too :D Dec 15 17:03:45 So I guess I can PR that soon too Dec 15 18:42:47 good, we're getting there :) Dec 15 18:51:52 Tofe_: Yeah will PR connman stuff Dec 15 18:52:12 We might need to add in telephony still but that's a fairly simple patch Dec 15 18:52:20 And update connman-conf a bit Dec 15 18:52:38 We blacklist p2p for example now while OSE provides that Dec 15 18:53:10 With all the API's we might be able to drop some of the libconnman-qt stuff and use LS2 calls instead Dec 15 18:53:25 But that's a design choice for later Dec 15 18:58:23 Same for BT stuff once I migrate OSE components in for BT Dec 15 19:02:23 For phone via connman I meant this patch:https://github.com/webOS-ports/webos-connman-adapter/commit/d1841e9b681b228a7a89ef68c2949db4f1b4b92d Dec 15 19:02:46 For the rest the one from OSE seems decent enough Dec 15 21:19:16 isn't libconnman-qt used indirectly by our phone app? Dec 15 21:19:55 (open question, I didn't check yet) Dec 15 21:35:15 Tofe_: Need to see, I think that was some ofono component Dec 15 21:35:39 I think at some point we took some of the SFOS qml components because they were easier Dec 15 21:35:57 Especially for BT Dec 15 21:36:10 But if we have LS2 that should be prefered way imho Dec 15 21:36:15 But we'd need to see Dec 15 21:37:06 well, if they provide the same level of functionality, switching the backend shouldnn't be very hard Dec 15 21:37:49 and it's not even the backend, just the middleware, actually Dec 15 21:38:10 My thought is that having LS2 calls on proven LG stack is better vs botches SFOS middleware that works with heavily patched SFOS connman etc Dec 15 21:38:24 I agree Dec 15 21:38:30 s/botches/botched Dec 15 21:38:39 But you get my drift Dec 15 21:39:05 Some things are done quite differently in SFOS and not always for the better Dec 15 21:39:40 But we'll cross that bridge when we get there Dec 15 21:41:03 Bedtime here, hope to PR connman stuff tomorrow Dec 15 21:50:36 same here; gn8 ! **** ENDING LOGGING AT Fri Dec 16 02:59:56 2022